feat: custom snowflake epoch, various fixes#3
Open
shayypy wants to merge 6 commits intotheinternetfolks:mainfrom
Open
feat: custom snowflake epoch, various fixes#3shayypy wants to merge 6 commits intotheinternetfolks:mainfrom
shayypy wants to merge 6 commits intotheinternetfolks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm using this package to generate Snowflakes but I wanted to set a custom epoch that makes more sense for my project (I'll never have an ID from 1970-2023, so why bother keeping those 53 redundant years?).
At first I attempted to override
Snowflake.EPOCHbut this was not working for me in my environment (i.e. snowflakes with the same epoch were generated), and the readme seemed to imply that this parameter should be passed throughgenerateanyway. I also added anepochparameter toparseso that timestamps with a custom epoch can be parsed correctly.Unrelated changes that are also in this pull:
shard_idoption ongenerateisValidonly accepting ids with length19shift(start) parameter in doc